ARROW-1240: [JAVA] switch logback to version 1.2.3 to address#871
ARROW-1240: [JAVA] switch logback to version 1.2.3 to address#871mattdarwin wants to merge 2 commits intoapache:masterfrom mattdarwin:master
Conversation
mattdarwin
changed the title
mattdarwin
changed the title
|
Does shifting to this version cause us to shift to a different SLF4j version? I know there are some incompatibilities between versions. |
|
Is that @jacques-n? Seems you are logged in with a different GH account |
|
Hah! Yeah, it was me. I'm back to being myself now :) |
|
Well the regression tests all passed, without any other changes.
But I’ve also proposed upgrading slf4j as a separate PR, since that’s also quite out of date.
… On 20 Jul 2017, at 17:31, DremioQA ***@***.***> wrote:
Does shifting to this version cause us to shift to a different SLF4j version? I know there are some incompatibilities between versions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#871 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB3WlxLdvtMtmrWFjXrikbvlelVM-pe-ks5sP4DfgaJpZM4OeDic>.
|
|
Sorry I wasn't more clear in my question (and slow to respond). We depend heavily on Arrow and also use Logback (the same version as Arrow). I was asking whether the API of logback and slf4j is different between your proposed versions and the current versions. Being a library, we have to be cautious about when we should change cross dependencies. (Definitely think an update makes sense, need to figure out how to proceed.) |
|
logback's list of changes report the following non-breaking changes between 1.0.13 and 1.2.3:
Arrow uses slf4j 1.7.6, and the latest version is 1.7.25. So assuming logbook versions >1.1.4 also require SLF4J 1.7.16 or later, we need to upgrade slf4j. |
|
I had to open a new PR since I deleted the fork for this one. |
….2.3 This PR supercedes #871 (repo fork for that one was deleted) Author: Matt Darwin <(none)> Closes #879 from mattdarwin/ARROW-1240-upgrade-logback and squashes the following commits: caed163 [Matt Darwin] upgrading slf4j to 1.7.25
….2.3 This PR supercedes apache#871 (repo fork for that one was deleted) Author: Matt Darwin <(none)> Closes apache#879 from mattdarwin/ARROW-1240-upgrade-logback and squashes the following commits: caed163 [Matt Darwin] upgrading slf4j to 1.7.25
4 participants
No description provided.