ARROW-1239: [JAVA] upgrading git-commit-id-plugin#869
Closed
antonymayi wants to merge 1 commit intoapache:masterfrom
antonymayi:master
Closed
ARROW-1239: [JAVA] upgrading git-commit-id-plugin#869antonymayi wants to merge 1 commit intoapache:masterfrom antonymayi:master
antonymayi wants to merge 1 commit intoapache:masterfrom
antonymayi:master
Conversation
Contributor
|
Thanks @antonymayi! |
This was referenced Jan 10, 2023
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Currently used version of the git-commit-id-plugin maven plugin (2.1.9) doesn't work with recent git structures. This is for majority of the users not manifested since Arrow has the java maven root in the project subdirectory (`/java`) instead of top level so this plugin normally doesn't kick in if maven is executed from the subdirectory (usual case - ie `cd java; mvn install` - works fine) as the plugin doesn't see the `.git` directory but it does kick in and fail if executed from the main arrow top level dir as `mvn -f java/pom.xml install` (where the `.git` sits): ``` $ mvn -f java/pom.xml package ... [ERROR] Failed to execute goal pl.project13.maven:git-commit-id-plugin:2.1.9:revision (for-jars) on project arrow-java-root: Execution for-jars of goal pl.project13.maven:git-commit-id-plugin:2.1.9:revision failed: Bare Repository has neither a working tree, nor an index -> [Help 1] ``` Simple fix is upgrading the plugin to recent version (the minimal working version appears to be 2.1.13). This is required for seamless integration with Jenkins (ARROW-1234). Author: Antony Mayi <[email protected]> Closes apache#869 from antonymayi/master and squashes the following commits: 6976ee0 [Antony Mayi] ARROW-1239 - upgrading git-commit-id-plugin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently used version of the git-commit-id-plugin maven plugin (2.1.9) doesn't work with recent git structures. This is for majority of the users not manifested since Arrow has the java maven root in the project subdirectory (
/java) instead of top level so this plugin normally doesn't kick in if maven is executed from the subdirectory (usual case - iecd java; mvn install- works fine) as the plugin doesn't see the.gitdirectory but it does kick in and fail if executed from the main arrow top level dir asmvn -f java/pom.xml install(where the.gitsits):Simple fix is upgrading the plugin to recent version (the minimal working version appears to be 2.1.13).
This is required for seamless integration with Jenkins (ARROW-1234).