ARROW-10396: [Rust] [Parquet] Publically export SliceableCursor and FileSource#8534
Closed
alamb wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-10396: [Rust] [Parquet] Publically export SliceableCursor and FileSource#8534alamb wants to merge 3 commits intoapache:masterfrom
alamb wants to merge 3 commits intoapache:masterfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
…eSource, Add Seek and Debug
alamb
force-pushed
the
alamb/ARROW-10396-expose-helpers
branch
from
67db2cb to
15d5fff
Compare
alamb
changed the title
alamb
commented
Oct 27, 2020
| inner: Rc<Vec<u8>>, | ||
| } | ||
|
|
||
| impl fmt::Debug for SliceableCursor { |
Contributor
Author
There was a problem hiding this comment.
I used this formulation rather than [#derive(Debug)] to avoid getting the buffer contents dumped which can be lots of data to sort through.
alamb
changed the title
Contributor
Author
jorgecarleitao
changed the title
Contributor
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
7155cd5 / #8300 Reworked how the parquet reader traits were implemented to be interms of a
ChunkReadertrait (for the better, in my opinion).That commit includes two helper classes,
SliceableCursorandFileSource, which implementChunkReaderfor aCursorlike thing andFiles, respectively.My project instantiates a
SerializedFileWriterfrom the parquet crate withstructs that wrapFileandCursorand thus I would like to re-use the logic inSliceableCursorandFileSourcewithout having to copy/paste them.Changes
SliceableCursorandFileSourceSeekfor SliceableCursorDebugfor bothSliceableCursorandFileSource