ARROW-7531: [C++] Reduce header inclusion cost slightly#8511
Closed
pitrou wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-7531: [C++] Reduce header inclusion cost slightly#8511pitrou wants to merge 2 commits intoapache:masterfrom
pitrou wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
I'll note the main offender when compiling the tests is |
pitrou
force-pushed
the
ARROW-7531-header-reduction
branch
from
74fa16a to
6c82a85
Compare
bkietz
approved these changes
Oct 22, 2020
Remove inclusion of heavyweights "arrow/api.h" and "arrow/builder.h", among other changes. This seems to reduce CPU build time by about 3%.
pitrou
force-pushed
the
ARROW-7531-header-reduction
branch
from
6c82a85 to
1876862
Compare
Member
Author
|
Rebased, will merge if CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove inclusion of heavyweights "arrow/api.h" and "arrow/builder.h", among other changes.
This seems to reduce CPU build time by about 3%.