ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector#8483
Closed
HedgehogCode wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-10333: [Java] Get rid of org.apache.arrow.util in vector#8483HedgehogCode wants to merge 1 commit intoapache:masterfrom
HedgehogCode wants to merge 1 commit intoapache:masterfrom
Conversation
HedgehogCode
changed the title
HedgehogCode
changed the title
kszucs
force-pushed
the
fix-split-packages
branch
from
1e10040 to
3fb2d03
Compare
liyafan82
reviewed
Oct 20, 2020
Contributor
There was a problem hiding this comment.
This line should be placed after the next line, to maintain the import order
Contributor
Author
There was a problem hiding this comment.
True. I changed it.
Contributor
There was a problem hiding this comment.
We need to import it only once
Contributor
Author
There was a problem hiding this comment.
Sorry about that. Must have happened during the rebasing of my local changes. It's finally fixed now.
HedgehogCode
force-pushed
the
fix-split-packages
branch
from
3fb2d03 to
8d3e452
Compare
The package org.apache.arrow.util was present in the artifacts arrow-vector and arrow-vector-memory-core. Split packages are a problem for OSGI and the Java 9+ modules (JPMS). This commit moves the classes AutoClosables and Collections2 to arrow-memory-core because they are generally useful and have no coupling with arrow-vector. The class DataSizeRoundingUtil is tighter coupled with arrow-vector and is therefore moved to the package org.apache.arrow.vector.util.
HedgehogCode
force-pushed
the
fix-split-packages
branch
from
8d3e452 to
eecc8cd
Compare
liyafan82
approved these changes
Oct 21, 2020
Contributor
liyafan82
left a comment
liyafan82
left a comment
There was a problem hiding this comment.
LGTM, will merge soon if there are no more comments.
Contributor
|
Merging. Thanks for the patch @HedgehogCode |
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
The package `org.apache.arrow.util` was present in the artifacts arrow-vector and arrow-vector-memory-core. Split packages are a problem for OSGI and the Java 9+ modules (JPMS). This PR moves the classes `AutoClosables` and `Collections2` to arrow-memory-core because they are generally useful and have no coupling with arrow-vector. The class `DataSizeRoundingUtil` is tighter coupled with arrow-vector and is therefore moved to the package `org.apache.arrow.vector.util`. Closes apache#8483 from HedgehogCode/fix-split-packages Authored-by: Benjamin Wilhelm <[email protected]> Signed-off-by: liyafan82 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package
org.apache.arrow.utilwas present in the artifacts arrow-vector and arrow-vector-memory-core. Split packages are a problem for OSGI and the Java 9+ modules (JPMS).This PR moves the classes
AutoClosablesandCollections2to arrow-memory-core because they are generally useful and have no coupling with arrow-vector.The class
DataSizeRoundingUtilis tighter coupled with arrow-vector and is therefore moved to the packageorg.apache.arrow.vector.util.