ARROW-10294: [Java] Resolve problems of DecimalVector APIs on ArrowBufs#8455
Closed
liyafan82 wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-10294: [Java] Resolve problems of DecimalVector APIs on ArrowBufs#8455liyafan82 wants to merge 1 commit intoapache:masterfrom
liyafan82 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
+1 LGTM. |
kszucs
pushed a commit
that referenced
this pull request
Oct 19, 2020
Unlike other fixed width vectors, DecimalVectors have some APIs that directly manipulate an ArrowBuf (e.g. `void set(int index, int isSet, int start, ArrowBuf buffer)`. After supporting 64-bit ArrowBufs, we need to adjust such APIs so that they work properly. Closes #8455 from liyafan82/fly_1012_dec Authored-by: liyafan82 <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Unlike other fixed width vectors, DecimalVectors have some APIs that directly manipulate an ArrowBuf (e.g. `void set(int index, int isSet, int start, ArrowBuf buffer)`. After supporting 64-bit ArrowBufs, we need to adjust such APIs so that they work properly. Closes apache#8455 from liyafan82/fly_1012_dec Authored-by: liyafan82 <[email protected]> Signed-off-by: Micah Kornfield <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike other fixed width vectors, DecimalVectors have some APIs that directly manipulate an ArrowBuf (e.g.
void set(int index, int isSet, int start, ArrowBuf buffer).After supporting 64-bit ArrowBufs, we need to adjust such APIs so that they work properly.