ARROW-10287: [C++] Avoid std::random_device#8444
Closed
pitrou wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-10287: [C++] Avoid std::random_device#8444pitrou wants to merge 3 commits intoapache:masterfrom
pitrou wants to merge 3 commits intoapache:masterfrom
Conversation
std::random_device may block on some systems, even for long times.
pitrou
force-pushed
the
ARROW-10287-avoid-dev-random
branch
from
3fb4325 to
2831af4
Compare
Member
Author
bkietz
approved these changes
Oct 12, 2020
Member
Author
|
@github-actions crossbow submit conda-cpp-valgrind |
Member
Author
|
@crossbow submit conda-cpp-valgrind |
Member
Author
|
This PR now also fixes the Valgrind failures. |
Member
|
Thanks Antoine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::random_device may block on some systems, even for long times.