Skip to content

ARROW-10286: [C++][FlightRPC] Make CMake output less confusing#8442

Closed
lidavidm wants to merge 1 commit intoapache:masterfrom
lidavidm:arrow-10286
Closed

ARROW-10286: [C++][FlightRPC] Make CMake output less confusing#8442
lidavidm wants to merge 1 commit intoapache:masterfrom
lidavidm:arrow-10286

Conversation

@lidavidm
Copy link
Copy Markdown
Member

  • Check DEFINED to avoid re-running the check on every CMake invocation
  • Log compiler output at DEBUG level to avoid dumping it by default
  • Use CMAKE_MESSAGE_INDENT to make it clearer that this is the output of a subcommand

@github-actions
Copy link
Copy Markdown

@lidavidm
Copy link
Copy Markdown
Member Author

cc @pitrou

Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants