ARROW-10262: [C++] Fix TypeClass for BinaryScalar and LargeBinaryScalar#8423
Closed
zanmato1984 wants to merge 1 commit intoapache:masterfrom
zanmato1984:arrow-10262
Closed
ARROW-10262: [C++] Fix TypeClass for BinaryScalar and LargeBinaryScalar#8423zanmato1984 wants to merge 1 commit intoapache:masterfrom zanmato1984:arrow-10262
zanmato1984 wants to merge 1 commit intoapache:masterfrom
zanmato1984:arrow-10262
Conversation
pitrou
approved these changes
Oct 12, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1. Thank you @zanmato1984 for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alias
TypeClassinBinaryScalarandLargeBinaryScalarare seemingly typo-ed to beBinaryScalarandLargeBinaryScalar. This causes issues when usingScalarType::TypeClass, esp. withTypeTrait- i.e., compiler complains that there are no whatever members in specializedTypeTrait<BinaryScalar>andTypeTrait<LargeBinaryScalar>.Fixing them to
BinaryTypeandLargeBinaryType.