ARROW-10099: [C++][Dataset] Simplify type inference for partition columns#8367
Closed
bkietz wants to merge 7 commits intoapache:masterfrom
Closed
ARROW-10099: [C++][Dataset] Simplify type inference for partition columns#8367bkietz wants to merge 7 commits intoapache:masterfrom
bkietz wants to merge 7 commits intoapache:masterfrom
Conversation
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
I like the simplification!
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
Co-authored-by: Joris Van den Bossche <[email protected]>
jorisvandenbossche
approved these changes
Oct 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed cardinality considerations for inferring partition field types. There is now a boolean flag (
inspect_dictionary, default false) which if set causes fields to be inferred as a dictionary encoded type instead of the corresponding value type.