ARROW-8205: [Rust] [DataFusion] Added check to uniqueness of column names.#8334
Closed
jorgecarleitao wants to merge 2 commits intoapache:masterfrom
jorgecarleitao:check_schema
Closed
ARROW-8205: [Rust] [DataFusion] Added check to uniqueness of column names.#8334jorgecarleitao wants to merge 2 commits intoapache:masterfrom jorgecarleitao:check_schema
jorgecarleitao wants to merge 2 commits intoapache:masterfrom
jorgecarleitao:check_schema
Conversation
Member
Author
|
The tests are currently failing due to ARROW-10170 |
alamb
approved these changes
Oct 4, 2020
Contributor
There was a problem hiding this comment.
I think this change is good (and the well worded error message will be appreciated by users for years to come!)
The only thing I could think of would be to apply the validate_unique_names check to all logical plan nodes (specifically, I think there might be issues if an input table scan or parquet file) had duplicate field names.
However, this code is better than what is on master so I think it could be merged as is too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check, during logical planning, to the uniqueness of column names after a projection and aggregation.
This eliminates the risk that a user creates a wrong logical query by the first column named X when there are two columns named X.
This does not eliminate this risk when the column name is duplicated on a scan.