ARROW-9753: [Rust] [DataFusion] Replaced Arc<Mutex<>> by Box<>#8307
Closed
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:box_iterator
Closed
ARROW-9753: [Rust] [DataFusion] Replaced Arc<Mutex<>> by Box<>#8307jorgecarleitao wants to merge 1 commit intoapache:masterfrom jorgecarleitao:box_iterator
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:box_iterator
Conversation
alamb
reviewed
Oct 1, 2020
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
FWIW the idea of getting rid of the mutex looks good to me. I am curious if you had a reason to prefer Box over Arc? If we use a Box, then anyone who wants to share results will have to either convert from Box --> Arc or will have to copy the entire Box.
Member
Author
|
I think that the reason is that an iterator like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #8225 and Replaces
Arc<Mutex<dyn ...>>byBox<dyn ...>.In the TopK example, I had to move some functions away from the
impl. This is becauseselfcannot be borrowed as mutable and immutable at the same time, and, during iteration, it was being borrowed as mutable (to update the BTree) and as immutable (to access theinput). There is probably a better way of achieving this e.g. via interior mutability.