ARROW-10041: [Rust] Added check of data type to GenericString::from.#8296
Closed
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:check_datatypes
Closed
ARROW-10041: [Rust] Added check of data type to GenericString::from.#8296jorgecarleitao wants to merge 1 commit intoapache:masterfrom jorgecarleitao:check_datatypes
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:check_datatypes
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
jorgecarleitao
changed the title
nevi-me
approved these changes
Oct 5, 2020
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
Thanks, I like that this removes the need to pass a datatype separately in some of the kernels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug on which GenericStringArray::from(ArrayData) was able to be created with the wrong DataType.
It also simplifies generics that use
GenericStringArray, as they no longer need to pass the correspondingDataTypeand can instead rely on aconstto do it for them.