ARROW-9977: [Rust] Added min/max of [Large]StringArray#8215
Closed
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:max_string
Closed
ARROW-9977: [Rust] Added min/max of [Large]StringArray#8215jorgecarleitao wants to merge 1 commit intoapache:masterfrom jorgecarleitao:max_string
jorgecarleitao wants to merge 1 commit intoapache:masterfrom
jorgecarleitao:max_string
Conversation
Member
Author
|
Rebased. |
alamb
approved these changes
Sep 18, 2020
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I think the logic is correct. I have a test and a style suggestion, but I think this could be merged as is.
Contributor
There was a problem hiding this comment.
I think you could also use an option here rather than a flag + value.
So something like let mut n = None;
And then instead of
has_value = true;
n = item;
something like
n = Some(item);
Contributor
There was a problem hiding this comment.
then you could return n directly
Member
Author
|
This was merged as part of #8172 and will thus be closed. I also marked the respective Jira issue as done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that, contrarily to horizontal operations, that we can represent as
f(&ArrayRef) -> ArrayRef, in vertical operations likeminandsum, we do not have a dynamically-typed struct to return, and thus need to have a function signature for each type. :(I wonder if we could have in Rust a dynamically struct for single values, like DataFusion has ScalarValue.