ARROW-9859: [C++] Decode username and password in URIs#8185
Closed
pitrou wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-9859: [C++] Decode username and password in URIs#8185pitrou wants to merge 2 commits intoapache:masterfrom
pitrou wants to merge 2 commits intoapache:masterfrom
Conversation
Allow passing a %-encoded secret key in a S3 URI. Also, detect and report unrecognized options in S3 URIs.
Member
Author
|
@nealrichardson I've checked this fixes the issue with a S3 URI from Python. |
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
The new tests LGTM, just a couple of other questions
nealrichardson
approved these changes
Sep 14, 2020
Member
Author
|
CI failures look unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing a %-encoded secret key in a S3 URI.
Also, detect and report unrecognized options in S3 URIs.