ARROW-9990: [Rust] [DataFusion] Fixed the NOT operator#8183
Closed
jorgecarleitao wants to merge 3 commits intoapache:masterfrom
jorgecarleitao:fix_not
Closed
ARROW-9990: [Rust] [DataFusion] Fixed the NOT operator#8183jorgecarleitao wants to merge 3 commits intoapache:masterfrom jorgecarleitao:fix_not
jorgecarleitao wants to merge 3 commits intoapache:masterfrom
jorgecarleitao:fix_not
Conversation
jhorstmann
reviewed
Sep 16, 2020
Contributor
|
LGTM |
andygrove
approved these changes
Sep 16, 2020
alamb
reviewed
Sep 18, 2020
| right: Box::new(self.sql_to_rex(&right, &schema)?), | ||
| }) | ||
| } | ||
| Ok(Expr::BinaryExpr { |
nevi-me
pushed a commit
that referenced
this pull request
Sep 23, 2020
Needs to be rebased after #8183 is merged Closes #8204 from jhorstmann/ARROW-10016-implement-is-null-kernels Authored-by: Jörn Horstmann <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #8182
This PR fixes the operator NOT, that currently cannot be logically planned. It was also an operator that was considered a Binary, even though it accepts only a single argument.