Skip to content

ARROW-9986: [Rust] allow to_timestamp to parse local times without fractional seconds#8179

Closed
alamb wants to merge 1 commit intoapache:masterfrom
alamb:alamb/ARROW-9986-fractional-secs
Closed

ARROW-9986: [Rust] allow to_timestamp to parse local times without fractional seconds#8179
alamb wants to merge 1 commit intoapache:masterfrom
alamb:alamb/ARROW-9986-fractional-secs

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented Sep 13, 2020

As pointed out on @jhorstmann: #8161 (comment)

One (not directly related) issue I noticed while trying this out, is that the local patterns seem to require the millisecond part, while for utc timestamps with "Z" they are optional:

> select to_timestamp('2020-09-12T10:30:00') from test limit 1;
ArrowError(ExternalError(General("Error parsing \'2020-09-12T10:30:00\' as timestamp")))

> select to_timestamp('2020-09-12T10:30:00Z') from test limit 1;
+-------------------------------------------+
| totimestamp(Utf8("2020-09-12T10:30:00Z")) |
+-------------------------------------------+
| 1599906600000000000                       |
+-------------------------------------------+

This PR allows parsing local timestamp patterns without the fractional seconds and tests for same

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 13, 2020

https://issues.apache.org/jira/browse/ARROW-9986

@nevi-me
Copy link
Copy Markdown
Contributor

nevi-me commented Sep 13, 2020

@alamb these timestamp conversions could be useful as compute kernels (https://github.com/apache/arrow/blob/master/rust/arrow/src/compute/kernels/temporal.rs), so perhaps something to consider in future :)

@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented Sep 14, 2020 •
edited
Loading

these timestamp conversions could be useful as compute kernels

Thanks @nevi-me -- I will add that to my list of potentials!

@alamb alamb force-pushed the alamb/ARROW-9986-fractional-secs branch from 14260c2 to e2ea6b2 Compare September 14, 2020 11:35
@paddyhoran paddyhoran changed the title ARROW-9986: allow to_timestamp to parse local times without fractional seconds ARROW-9986: [Rust] allow to_timestamp to parse local times without fractional seconds Sep 15, 2020
@andygrove andygrove closed this in 2f621fc Sep 16, 2020
@alamb alamb deleted the alamb/ARROW-9986-fractional-secs branch October 26, 2020 20:04
@asfimport asfimport mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygrove andygrove andygrove approved these changes

Assignees

No one assigned

Labels

Component: Rust - DataFusion Component: Rust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb @nevi-me @andygrove @paddyhoran