ARROW-9979: [Rust] Fix arrow crate clippy lints#8168
ARROW-9979: [Rust] Fix arrow crate clippy lints#8168nevi-me wants to merge 2 commits intoapache:masterfrom
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I skimmed the changes and overall I think they look like a good improvement to me (especially the removal of vec! and clone() calls. Nice work
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot!
I would be fine to place clippy under CI checks and READMEs to reduce merge conflicts during rebasing on top of these type of commits.
nevi-me
changed the title
|
Thanks @alamb @jorgecarleitao, I've opened https://issues.apache.org/jira/browse/ARROW-9978 to keep track of all clippy work. I'll wait for @andygrove and @paddyhoran's opinions before going ahead with the merge. It's unfortunately going to be disruptive to existing open PRs, but at the same time I'd like to merge this sooner so I can bank this work (it's the third time I work on clippy lints) |
4 participants
This fixes a lot of clippy errors and warnings. We currently have over 600 such, and they tend to cause a lot of noise while working.
This PR only includes changes to arrow, one change to datafusion and integration testing. I've left parquet out to potentially open a separare PR.
Thoughts @andygrove @alamb @jorgecarleitao @paddyhoran?