ARROW-9465: [Python] Improve ergonomics of compute module#8163
Closed
pitrou wants to merge 4 commits intoapache:masterfrom
Closed
ARROW-9465: [Python] Improve ergonomics of compute module#8163pitrou wants to merge 4 commits intoapache:masterfrom
pitrou wants to merge 4 commits intoapache:masterfrom
Conversation
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Nice improvements!
python/pyarrow/_compute.pyx
Outdated
Member
There was a problem hiding this comment.
Should "meta" be explained here as well?
Member
There was a problem hiding this comment.
Can we simply change this? (is it public on the C++ side?) And it is changed for consistency with how it's called elsewhere?
Member
Author
There was a problem hiding this comment.
The next version will be 2.0.0, meaning it's ok to break APIs. Of course, we should try to minimize breakage, but this one aims to fix an inconsistency.
Lots of assorted things here: * Automatically generate global wrappers for calling registered compute functions * Improve metadata of such wrappers (e.g. name, docstring) * Make it easier to pass options (for example via kwargs) * Type-check options * Add some docstrings * Expose more function attributes (e.g. arity) * Fix some crashes
pitrou
force-pushed
the
ARROW-9465-py-compute-cosmetics
branch
from
7cce626 to
648ee85
Compare
Member
Author
|
CI failures here look unrelated (though someone should really take a look at them). |
pitrou
added a commit
that referenced
this pull request
Oct 8, 2020
…sses #8163 exposes `pyarrow.compute` kernels and generates their docstrings. This PR adds documentation for the module in the User Guide and the Python API reference. Closes #8145 from arw2019/ARROW-7871 Lead-authored-by: arw2019 <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of assorted things here:
registered compute functions