ARROW-7215: [C++][Gandiva] Implement castVARCHAR(numeric_type) functions #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projjal
force-pushed
the
castvarchar
branch
8 times, most recently
from
eece673 to
f1dbfbe
Compare
Contributor
Author
|
@wesm This pr fails in windows with a LINK error during build (during creating the unit test binary). Do you have an idea why this is failing in windows. Or is there any remote windows machine for arrow devs where I can try out and investigate myself (unfortunately I don't have a personal windows machine)? |
Member
Either you need to statically-link these symbols (or include them with the .cc files / object code for the unit test) or add an appropriate export annotation for the functions so they will link from the DLL |
projjal
force-pushed
the
castvarchar
branch
3 times, most recently
from
d5f4e32 to
dc97693
Compare
Contributor
Author
|
Thanks @wesm |
jorgecarleitao
force-pushed
the
master
branch
from
d4608a9 to
356c300
Compare
praveenbingo
pushed a commit
that referenced
this pull request
Apr 15, 2021
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the #8158 PR to change the function output to match the Java language patterns. Closes #9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <[email protected]> Co-authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
projjal
added a commit
to projjal/arrow
that referenced
this pull request
Apr 21, 2021
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache#8158 PR to change the function output to match the Java language patterns. Closes apache#9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a5 <Anthony Louis> Apply formatting changes 7a724c0 <Anthony Louis> Remove unnecessary macros 4fb8a7f <Anthony Louis> Refactor if chain e787051 <Anthony Louis> Add test to infinity case b62b856 <Anthony Louis> Add comments for changes cec11bb <Anthony Louis> Add tests to check Java compatibility 302139c <Anthony Louis> Add emit trailing point tests efb94b9 <Anthony Louis> Add -0.0 inside cast test 523e60a <Anthony Louis> Add custom constructor inside the class 34f2f92 <Anthony Louis> Add class to print in formatted way e244502 <Anthony Louis> Fix tests to consider java formatting 33bc5b2 <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <[email protected]> Co-authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
kou
pushed a commit
to apache/arrow-java
that referenced
this pull request
Nov 25, 2024
This PR implements the castVARCHAR for numeric values inside the Gandiva. It replaces the logic of the apache/arrow#8158 PR to change the function output to match the Java language patterns. Closes #9816 from anthonylouisbsb/feature/fix-castvarchar-to-match-java-impl and squashes the following commits: 7df55a58d <Anthony Louis> Apply formatting changes 7a724c0fd <Anthony Louis> Remove unnecessary macros 4fb8a7f44 <Anthony Louis> Refactor if chain e78705136 <Anthony Louis> Add test to infinity case b62b856a0 <Anthony Louis> Add comments for changes cec11bbf0 <Anthony Louis> Add tests to check Java compatibility 302139c78 <Anthony Louis> Add emit trailing point tests efb94b901 <Anthony Louis> Add -0.0 inside cast test 523e60a56 <Anthony Louis> Add custom constructor inside the class 34f2f926d <Anthony Louis> Add class to print in formatted way e244502b3 <Anthony Louis> Fix tests to consider java formatting 33bc5b2de <Projjal Chanda> added castvarchar(numeric_types) functions Lead-authored-by: Anthony Louis <[email protected]> Co-authored-by: Projjal Chanda <[email protected]> Signed-off-by: Praveen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.