ARROW-9954: [Rust] [DataFusion] Made aggregates support the same signatures as functions.#8155
Closed
jorgecarleitao wants to merge 2 commits intoapache:masterfrom
jorgecarleitao:aggregates
Closed
ARROW-9954: [Rust] [DataFusion] Made aggregates support the same signatures as functions.#8155jorgecarleitao wants to merge 2 commits intoapache:masterfrom jorgecarleitao:aggregates
jorgecarleitao wants to merge 2 commits intoapache:masterfrom
jorgecarleitao:aggregates
Conversation
andygrove
approved these changes
Sep 10, 2020
Member
andygrove
left a comment
andygrove
left a comment
There was a problem hiding this comment.
LGTM! Thanks @jorgecarleitao this is another great improvement.
alamb
approved these changes
Sep 10, 2020
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
looks good to me -- nice work @jorgecarleitao
This commit makes the creation of aggregate expressions similar to the creation of built-in expressions. This allows to share coercion rules and signatures between the physical and logical planes, as well as support aggregates of multiple columns (e.g. "cov").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the creation of aggregate expressions similar to the creation of built-in expressions.
This allows to share coercion rules and signatures between scalar and aggregate functions.