ARROW-9271: [R] Preserve data frame metadata in round trip#8150
Closed
romainfrancois wants to merge 7 commits intoapache:masterfrom
Closed
ARROW-9271: [R] Preserve data frame metadata in round trip#8150romainfrancois wants to merge 7 commits intoapache:masterfrom
romainfrancois wants to merge 7 commits intoapache:masterfrom
Conversation
nealrichardson
requested changes
Sep 9, 2020
Contributor
Author
|
I think this can be followed up with something that specifically deals with POSIXlt |
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
One note, which I can take care of later today if you don't get to it.
nealrichardson
approved these changes
Sep 11, 2020
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Thanks, will merge when green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified the internal code and moved some things to the R layer. This should make it easier to alter which attribute is kept for various types.