ARROW-9917: [Python][Compute] Bindings for mode kernel#8115
Closed
arw2019 wants to merge 4 commits intoapache:masterfrom
Closed
ARROW-9917: [Python][Compute] Bindings for mode kernel#8115arw2019 wants to merge 4 commits intoapache:masterfrom
arw2019 wants to merge 4 commits intoapache:masterfrom
Conversation
python/pyarrow/array.pxi
Outdated
Member
There was a problem hiding this comment.
I am not sure we necessarily want to add it as a Array method as well. For a starter, it's also not a method on a numpy array (so convenient consistency with numpy is already not an argument). In general we don't expose all compute functions also as methods (but currently the line is not very clear ... )
pitrou
reviewed
Sep 7, 2020
python/pyarrow/tests/test_compute.py
Outdated
Member
There was a problem hiding this comment.
We don't need to test multiple types and values agggressively, since that it already done on the C++ side. Mostly we should check that the Python wrapper has the expected API and return type.
jorisvandenbossche
approved these changes
Sep 8, 2020
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks for the update!
Contributor
Author
|
thanks @jorisvandenbossche @pitrou for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.