ARROW-9079: [C++] Write benchmark for arithmetic kernels#7417
Closed
kszucs wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-9079: [C++] Write benchmark for arithmetic kernels#7417kszucs wants to merge 3 commits intoapache:masterfrom
kszucs wants to merge 3 commits intoapache:masterfrom
Conversation
kszucs
commented
Jun 12, 2020
Member
|
Thanks for working on this. I'll check the benchmarks on MSVC also |
Member
|
There don't seem to be issues on MSVC |
wesm
reviewed
Jun 12, 2020
…rrays. Add items processed output
Member
|
+1. I fixed a few lingering issues that jumped out at me, will merge this once build passes |
wesm
reviewed
Jun 13, 2020
| bench->Unit(benchmark::kMicrosecond); | ||
|
|
||
| for (const auto size : kMemorySizes) { | ||
| for (const auto size : {kL1Size, kL2Size}) { |
Member
There was a problem hiding this comment.
I have a processor with 22MB L3 cache so generating that much random data is quite expensive. If we want to benchmark arrays that big we should generate a smaller sample of random data and repeat/tile it to make the bigger array.
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quickly wanted to add a benchmark for the
Addfunction to verify that no significant regressions were introduced by #7341Before:
After:
cc @wesm