ARROW-8793: [C++] Do not inline BitUtil::SetBitsTo#7296
Closed
wesm wants to merge 2 commits intoapache:masterfrom
Closed
ARROW-8793: [C++] Do not inline BitUtil::SetBitsTo#7296wesm wants to merge 2 commits intoapache:masterfrom
wesm wants to merge 2 commits intoapache:masterfrom
Conversation
Member
Author
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local benchmarks suggest that there is 3-4 ns of overhead for manipulating small bitmaps when it is not inline.
inline (argument is byte size of bitmap):
non-inline:
If it can be demonstrated that inlining can meaningfully improve the macroperformance of some function, then we could lift the implementation into a
SetBitsToInline, but until then I think it makes sense to keep it in bit_util.cc