ARROW-5854: [Python] Expose compare kernels on Array class#7273
ARROW-5854: [Python] Expose compare kernels on Array class#7273jorisvandenbossche wants to merge 2 commits intoapache:masterfrom
Conversation
|
I wanted to add the same to ChunkedArray, but it seems that for ChunkedArray we already defined Is that something we want to (hard) break? |
|
@jorisvandenbossche I'm OK with changing |
python/pyarrow/array.pxi
Outdated
There was a problem hiding this comment.
Maybe factor this out into a helper function to avoid the code duplication?
There was a problem hiding this comment.
Moved the op to function name conversion into a helper function
python/pyarrow/tests/test_compute.py
Outdated
There was a problem hiding this comment.
Is there a JIRA about adding a pyarrow.scalar function (in order to do pa.scalar(2) here)?
python/pyarrow/tests/test_compute.py
Outdated
There was a problem hiding this comment.
Can you add a case to show comparing with a null scalar?
There was a problem hiding this comment.
I am not directly sure how to create an actual null scalar (the pa.array([None]).sum() trick doesn't work, because the sum or minmax kernel is not implemented for null type)
jorisvandenbossche
force-pushed
the
ARROW-5854-array-compare
branch
from
142a4fd to
e1623b3
Compare
|
Updated to add the comparison ops to ChunkedArray as well |
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1. The CI failure is ARROW-8999, I've seen it in other PRs so don't think it's related to this
2 participants
No description provided.