ARROW-3329: [Python] Python tests for decimal to int and decimal to decimal casts#6846
Closed
JacekPliszka wants to merge 2 commits intoapache:masterfrom
JacekPliszka:ARROW-3329
Closed
ARROW-3329: [Python] Python tests for decimal to int and decimal to decimal casts#6846JacekPliszka wants to merge 2 commits intoapache:masterfrom JacekPliszka:ARROW-3329
JacekPliszka wants to merge 2 commits intoapache:masterfrom
JacekPliszka:ARROW-3329
Conversation
Contributor
Author
|
I need help with the failure above - on my machine the test passes as pa.ArrowInvalid is returned. I added workaround for that - not sure if correct one. |
Added Python tests for decimal to integer and decimal to decimal casts. Minor problem remaining: * python cast does not distinguish between truncation and overflow - only safe option is present * no overflow implemented for decimal to decimal cast * cast while constructing is still failing
Member
|
I rebased and improved the tests slightly. Also opened some issues for some oddities. |
Member
|
The CI failure looks unrelated, will merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.