ARROW-1004: [Python] Add conversions for numpy object arrays with integers and floats#681
ARROW-1004: [Python] Add conversions for numpy object arrays with integers and floats#681wesm wants to merge 3 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
PyArray_IsIntegerScalar uses PyInt_Check with Python 3.4 and numpy==1.9.x Thus we probably need to raise our minimal NumPy version to >=1.10. For the manylinux1 build, you have to adjust it in python/manylinux1/scripts/build_virtualenvs.sh
There was a problem hiding this comment.
Please pin exactly here, we need the most minimal NumPy version at build time to stay compatible with as many numpy versions as possible.
|
I've made #684 to get a new base docker-image. |
There was a problem hiding this comment.
Any reason not to use RETURN_IF_PYERROR() here?
There was a problem hiding this comment.
Should this be PyFloat_AsDouble followed by RETURN_IF_PYERROR() to make sure that errors raised by Python are propagated?
There was a problem hiding this comment.
reasons why PyFloat_AsDouble would fail after passing PyFloat_Check seem esoteric to me, but I've changed it to be on the safe side
Change-Id: I69c2960b510fd5e1eeef66ac614b40019b545825
Change-Id: Id1f5aa57b6fd090dc295a956e2a91b74e333fd96
Change-Id: Icaf053db0b8141af18fe19a8e11e9541cc591af9
|
Cool, here is the appveyor build: https://ci.appveyor.com/project/wesm/arrow/build/1.0.431 |
…egers and floats Author: Wes McKinney <[email protected]> Closes apache#681 from wesm/ARROW-1004 and squashes the following commits: 9e0b2ea [Wes McKinney] Code review comments 45f1ecb [Wes McKinney] Fixes for manylinux1 4e4c752 [Wes McKinney] Add conversions for numpy object arrays with integers and floats
This PR updates to parent Apache POM 34 with new plugins versions.
3 participants
No description provided.