ARROW-8060: [Python] Make dataset Expression objects serializable#6702
Closed
kszucs wants to merge 6 commits intoapache:masterfrom
Closed
ARROW-8060: [Python] Make dataset Expression objects serializable#6702kszucs wants to merge 6 commits intoapache:masterfrom
kszucs wants to merge 6 commits intoapache:masterfrom
Conversation
kszucs
commented
Mar 24, 2020
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Thanks! added some comments
bkietz
requested changes
Mar 24, 2020
bkietz
reviewed
Mar 24, 2020
Member
|
Is there a JIRA about defining a e.g. Flatbuffers-based serialization protocol (probably better than Protobuf so we avoid having to introduce a library dependency) for expressions? Seems like it might provide a more scalable solution for serialization and could eventually succeed the strategy here |
Member
Author
bkietz
approved these changes
Mar 25, 2020
kszucs
commented
Mar 25, 2020
Member
Author
kszucs
left a comment
kszucs
left a comment
There was a problem hiding this comment.
+1, build failure is unrelated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scalar are not properly exposed yet and the C++ implementation will change soon so while the serialization will work, we need to refactor this code.