ARROW-1003: [C++] Check flag _WIN32 instead of __WIN32#669
Closed
bgosztonyi wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-1003: [C++] Check flag _WIN32 instead of __WIN32#669bgosztonyi wants to merge 1 commit intoapache:masterfrom
bgosztonyi wants to merge 1 commit intoapache:masterfrom
Conversation
__WIN32 is not standard for all windows compilers.
bgosztonyi
changed the title
Member
|
@bgosztonyi can you open a JIRA and add it to the PR title? Thanks! |
bgosztonyi
changed the title
wesm
approved these changes
May 10, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1. I will merge when the build runs -- if you activate Appveyor on your fork, you can get more timely builds
Member
|
Thanks for your contribution |
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
__WIN32 is not standard for all windows compilers. Author: bgosztonyi <[email protected]> Closes apache#669 from bgosztonyi/patch-1 and squashes the following commits: 618ab3e [bgosztonyi] _WIN32 instead of __WIN32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__WIN32 is not standard for all windows compilers.