Skip to content

ARROW-813: [Python] setup.py sdist must also bundle dependent cmake m…#660

Closed
xhochy wants to merge 3 commits intoapache:masterfrom
xhochy:ARROW-813
Closed

ARROW-813: [Python] setup.py sdist must also bundle dependent cmake m…#660
xhochy wants to merge 3 commits intoapache:masterfrom
xhochy:ARROW-813

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented May 8, 2017

…odules

wesm
wesm approved these changes May 8, 2017
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Will wait for build

@xhochy
Copy link
Member Author

xhochy commented May 8, 2017

This fails on Windows, solutions seems to be to run git config core.symlinks true before the build (see appveyor/ci#650) Not sure if that is a path we should go. cc @Maxris

@maxhora
Copy link
Contributor

maxhora commented May 8, 2017

@xhochy , usage of git config core.symlinks true looks much better than alternative script based solutions for Windows. It seems that on Windows created symlinks will not work with FAT32 filesystem, only with NTFS ( http://stackoverflow.com/a/11664406/2266412 ). Personally, I haven't seen wide usage of symlinks on Windows.

@xhochy
Copy link
Member Author

xhochy commented May 9, 2017

Apache RAT fails on compressed tarballs with symlinks, will ignore them for now but I raised an issue upstream: https://issues.apache.org/jira/browse/RAT-235

@wesm
Copy link
Member

wesm commented May 10, 2017

Appveyor still failing it seems, odd

@xhochy
Copy link
Member Author

xhochy commented May 10, 2017

Fixed: https://ci.appveyor.com/project/xhochy/arrow/build/1.0.317

@asfgit asfgit closed this in 1c6f3ef May 11, 2017
jeffknupp pushed a commit to jeffknupp/arrow that referenced this pull request Jun 3, 2017
@xhochy @jeffknupp
ARROW-813: [Python] setup.py sdist must also bundle dependent cmake m…
ce81c46 
…odules

Author: Uwe L. Korn <[email protected]>

Closes apache#660 from xhochy/ARROW-813 and squashes the following commits:

47459ba [Uwe L. Korn] Call git later
5b3b4a4 [Uwe L. Korn] Symlink fixes
70ca0d8 [Uwe L. Korn] ARROW-813: [Python] setup.py sdist must also bundle dependent cmake modules
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@lidavidm
apacheGH-81: [Flight] Expose gRPC in Flight client builder (apache#660)
8d3fe93 
## What's Changed

Expose the internal gRPC channel builder in the FlightClient so that
applications can build on top of it without having to replicate all the
special Flight logic. This makes it much easier to apply some gRPC
tweaks without duplicating Arrow code.

Closes apache#81.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xhochy @maxhora @wesm