ARROW-482 [Java] Exposing custom field metadata#611
Closed
elahrvivaz wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-482 [Java] Exposing custom field metadata#611elahrvivaz wants to merge 1 commit intoapache:masterfrom
elahrvivaz wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Since this might take some discussion, do you mind if this does not block the 0.3 release? I'd like to release 0.4 and beyond a little faster |
Contributor
Author
|
sure |
Member
|
overall this looks good to me. Opinions regarding making the removed Field constructors @deprecated rather than deleting them? |
Contributor
Author
|
That sounds good, I'll restore them and mark them deprecated. |
Member
|
@elahrvivaz can you rebase? @julienledem is this good to go? |
* Making non-FieldType constructors deprecated to ensure consistent vector creation
Contributor
Author
|
rebased |
Member
|
yep +1 |
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Jun 3, 2017
I added the metadata to the `FieldType` object. It doesn't necessarily seem the right place for it, but it minimizes having to change method signatures to pass around the metadata. I also tried to standardize vector constructors on `FieldType` to ensure it's passed correctly. Author: Emilio Lahr-Vivaz <[email protected]> Closes apache#611 from elahrvivaz/ARROW-482 and squashes the following commits: 63a76e0 [Emilio Lahr-Vivaz] ARROW-482 [Java] Exposing custom field metadata
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
I added the metadata to the `FieldType` object. It doesn't necessarily seem the right place for it, but it minimizes having to change method signatures to pass around the metadata. I also tried to standardize vector constructors on `FieldType` to ensure it's passed correctly. Author: Emilio Lahr-Vivaz <[email protected]> Closes apache#611 from elahrvivaz/ARROW-482 and squashes the following commits: 63a76e0 [Emilio Lahr-Vivaz] ARROW-482 [Java] Exposing custom field metadata
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the metadata to the
FieldTypeobject. It doesn't necessarily seem the right place for it, but it minimizes having to change method signatures to pass around the metadata. I also tried to standardize vector constructors onFieldTypeto ensure it's passed correctly.