Repository navigation
GH-55598: [C++][Parquet] Align Parquet-to-GeoArrow conversions with Parquet, GeoParquet, and arrow-rs - #55599
Open
paleolimbot wants to merge 1 commit into
Open
paleolimbot wants to merge 1 commit into
paleolimbot wants to merge 1 commit into
Conversation
|
Thanks for opening a pull request! This pull request has been automatically converted to a draft because its title doesn't match Arrow's required format. If this is not a minor PR, could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or After updating the title, you can mark the pull request as ready for review. See also: |
paleolimbot
changed the title
|
|
paleolimbot
marked this pull request as ready for review
November 13, 2026 18:26
Member
Author
|
cc @wgtmac and @jorisvandenbossche |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GeoArrow input to the Parquet reader with a "missing" CRS (
nullin GeoParquet,Nonein GeoPandas) are currently written with a Parquet CRS that denotes lon/lat and will roundtrip incorrectly when read back to GeoPandas/GeoArrow.What changes are included in this PR?
Adds a mapping between
srid:0and GeoArrow's "missing" CRS to match arrow-rs, GeoParquet, and the discussion aroundsrid:0in the Parquet format PR adding it as an example.Are these changes tested?
Yes, the parameterized geospatial logical type mapping tests in both directions were ported from arrow-rs and include srid:0.
Are there any user-facing changes?
Yes: under a very specific set of circumstances (GeoArrow extension types registered, Parquet
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
Closes #55598.