ARROW-1562: [C++] Numeric kernel implementations for add#5021
Closed
fexolm wants to merge 5 commits intoapache:masterfrom
Closed
ARROW-1562: [C++] Numeric kernel implementations for add#5021fexolm wants to merge 5 commits intoapache:masterfrom
fexolm wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
|
Multiple notes:
|
Contributor
|
@fexolm it looks like @fsaintjacques gave some feedback on implementation do you need more guidance? |
Contributor
Author
|
@emkornfield no, I just can not find the time to finish this. I will return to this as soon as I get time. |
Contributor
Author
|
@fsaintjacques, @emkornfield |
7a6f7e1 to
a60b42f
Compare
Contributor
|
Thanks @fexolm @fsaintjacques do you have time to review? |
Contributor
|
Will review again. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's just an initial AddKernel implementation (work in progress). I could not come up with a better implementation of type inference, so I want to hear your thoughts about implementation.