ARROW-5986: [Java] Code cleanup for dictionary encoding#4909
Closed
tianchen92 wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-5986: [Java] Code cleanup for dictionary encoding#4909tianchen92 wants to merge 1 commit intoapache:masterfrom
tianchen92 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
+1, LGTM. The 0.14.1 release candidate is already cut but it shouldn't have cherry-picked any of these changes. |
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
Related to [ARROW-5986](https://issues.apache.org/jira/browse/ARROW-5986). In last few weeks, we did some refactor in dictionary encoding. Since the new designed hash table for DictionaryEncoder and hashCode & equals API in ValueVector already checked in, some classed are no use anymore like DictionaryEncodingHashTable, BaseBinaryVector and related benchmarks & UT. Fortunately, these changes are not made into version 0.14, which makes possible to remove them. I think this should be merged before 0.14.1? @emkornfield Author: tianchen <[email protected]> Closes #4909 from tianchen92/ARROW-5986 and squashes the following commits: bd6d7af <tianchen> ARROW-5986: Code cleanup for dictionary encoding
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Related to [ARROW-5986](https://issues.apache.org/jira/browse/ARROW-5986). In last few weeks, we did some refactor in dictionary encoding. Since the new designed hash table for DictionaryEncoder and hashCode & equals API in ValueVector already checked in, some classed are no use anymore like DictionaryEncodingHashTable, BaseBinaryVector and related benchmarks & UT. Fortunately, these changes are not made into version 0.14, which makes possible to remove them. I think this should be merged before 0.14.1? @emkornfield Author: tianchen <[email protected]> Closes apache#4909 from tianchen92/ARROW-5986 and squashes the following commits: bd6d7af <tianchen> ARROW-5986: Code cleanup for dictionary encoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ARROW-5986.
In last few weeks, we did some refactor in dictionary encoding.
Since the new designed hash table for DictionaryEncoder and hashCode & equals API in ValueVector already checked in, some classed are no use anymore like DictionaryEncodingHashTable, BaseBinaryVector and related benchmarks & UT.
Fortunately, these changes are not made into version 0.14, which makes possible to remove them.
I think this should be merged before 0.14.1? @emkornfield