⚠️ GitHub issue #48740 has been automatically assigned in GitHub to PR creator.

I think that what you need is TypeTraits but not CTypeTraits

cc @zanmato1984

I think that what you need is TypeTraits but not CTypeTraits

Hi @HuaHuaY , this issue is specifically for CTypeTraits which are now missing for certain types (mostly Decimals).

I think that what you need is TypeTraits but not CTypeTraits

Hi @HuaHuaY , this issue is specifically for CTypeTraits which are now missing for certain types (mostly Decimals).

But I think that this PR is implementing types' TypeTraits instead of CTypeTraits. You can check the code around line 354 which is similar to this PR.

// line 354
template <>
struct TypeTraits<Decimal128Type> {
  ...
  using CType = Decimal128;
  ...
};

template <>
struct TypeTraits<Decimal256Type> {
  ...
  using CType = Decimal256;
  ...
};

// this PR
template <>
struct CTypeTraits<Decimal128Type> {
  using ArrowType = Decimal128Type;
  using CType = Decimal128;
};

template <>
struct CTypeTraits<Decimal256Type> {
  using ArrowType = Decimal256Type;
  using CType = Decimal256;
};

I guess that there should not be CType in CTypeTraits and arrow type should not be the template parameter. We may need these code instead, or you may use some other CType template parameter but I guess it should not be Decimal128Type itself:

template <>
struct CTypeTraits<Decimal128Type::CType> {
  using ArrowType = Decimal128Type;
};

template <>
struct CTypeTraits<Decimal256Type::CType> {
  using ArrowType = Decimal256Type;
};

template <>
struct CTypeTraits<Decimal128Type::CType> {
  using ArrowType = Decimal128Type;
};

template <>
struct CTypeTraits<Decimal256Type::CType> {
  using ArrowType = Decimal256Type;
};

I found that my understanding of this code isn't complete either. Referring to other implementations, CTypeTraits should inherit from TypeTraits.

Hi @zanmato1984 ,
could you please approve the pending GitHub Actions workflows for this PR?
I’ve updated the PR to include Decimal32/64 in addition to Decimal128/256.
Thanks!