ARROW-5880: [C++][Parquet] Use TypedBufferBuilder instead of ArrayBuilder in writer.cc#4827
Closed
emkornfield wants to merge 11 commits intoapache:masterfrom
Closed
ARROW-5880: [C++][Parquet] Use TypedBufferBuilder instead of ArrayBuilder in writer.cc#4827emkornfield wants to merge 11 commits intoapache:masterfrom
emkornfield wants to merge 11 commits intoapache:masterfrom
Conversation
Contributor
emkornfield
commented
Jul 9, 2019
emkornfield
commented
- Other small cleanups/comments based on my grokking of the code.
- Vectorize inner loop of List based LevelBuilder where possible
bkietz
requested changes
Jul 9, 2019
cpp/src/parquet/arrow/writer.cc
Outdated
Member
There was a problem hiding this comment.
Suggested change
| // arrays otherwise we would preallocate. An upper boun on memory | |
| // arrays otherwise we would preallocate. An upper bound on memory |
bkietz
reviewed
Jul 9, 2019
fsaintjacques
changed the title
emkornfield
changed the title
Contributor
Author
|
@bkietz thanks for the review, all good suggestions. |
Member
|
Added some missing exports. Beware as you make more changes on the Parquet codebase that my patch #4841 is slightly disruptive to the src/parquet/arrow directory (but should not be too bad to rebase) |
Contributor
Author
|
@wesm thanks for the fixes. I will look more closely as I modify code to watch out for potential merge conflicts (I have enough other things on my plate that it might be a few days anyways before I get back to this). I restarted the failing travis-CI job which looked spurious |
emkornfield
force-pushed
the
parquet_cleanup
branch
from
a14fbe5 to
94ce3e5
Compare
Co-Authored-By: Benjamin Kietzman <[email protected]>
Co-Authored-By: Benjamin Kietzman <[email protected]>
Co-Authored-By: Benjamin Kietzman <[email protected]>
emkornfield
force-pushed
the
parquet_cleanup
branch
from
94ce3e5 to
2f77313
Compare
Codecov Report
@@ Coverage Diff @@
## master #4827 +/- ##
==========================================
+ Coverage 87.31% 89.05% +1.74%
==========================================
Files 894 718 -176
Lines 134066 100316 -33750
==========================================
- Hits 117055 89334 -27721
+ Misses 16659 10982 -5677
+ Partials 352 0 -352
Continue to review full report at Codecov.
|
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
…lder in writer.cc - Other small cleanups/comments based on my grokking of the code. - Vectorize inner loop of List based LevelBuilder where possible Closes #4827 from emkornfield/parquet_cleanup and squashes the following commits: 2f77313 <Wes McKinney> Export operator<< symbols for DataType, TimeUnit on Windows e1698e5 <Micah Kornfield> fix compilation issues 152a6ee <Micah Kornfield> change back to signed it seems to be what the API uses 67ccf3e <Micah Kornfield> update references ef7fade <Micah Kornfield> remove unneeded nesting 6776e61 <emkornfield> Update cpp/src/parquet/arrow/writer.cc 7cbc8e4 <emkornfield> Update cpp/src/parquet/arrow/writer.cc 83ee5ae <emkornfield> Update cpp/src/parquet/arrow/writer.cc 325af52 <Micah Kornfield> undo reserve 4516110 <Micah Kornfield> Small style issues 7795352 <Micah Kornfield> change from array builder to buffer builde Lead-authored-by: Micah Kornfield <[email protected]> Co-authored-by: emkornfield <[email protected]> Co-authored-by: Wes McKinney <[email protected]> Signed-off-by: Wes McKinney <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.