ARROW-5863: [Python] Use atexit module for extension type finalization to avoid segfault#4824
Closed
wesm wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-5863: [Python] Use atexit module for extension type finalization to avoid segfault#4824wesm wants to merge 1 commit intoapache:masterfrom
wesm wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
Member
|
I'm not sure I understand the underlying cause either. It seems the module-wide |
Member
Author
|
I opened cython/cython#3039 |
Contributor
|
In order to prevent common cases for crashes or other weird behaviour at shutdown, module-level cleanup is not enabled by default. Does pyarrow use it? The comment in there is not entirely correct for Py3 anymore, where the cleanup is triggered by CPython's module object cleanup. That might not be at system exit but when actually unloading the module for whatever (rare) reason, even before exiting. It's still typically the system exit, though. |
Contributor
|
Updated the comment here. |
wesm
added a commit
that referenced
this pull request
Jul 13, 2019
…n to avoid segfault As reported on JIRA, the following script provokes a segfault ``` #! /usr/bin/env python import pyarrow import sys del sys.modules['pyarrow.lib'] ``` For some reason this does not trigger the destruction of the private `_ExtensionTypesInitializer` object. Not sure why (Antoine may know). Using the atexit module instead seems to do the trick Author: Wes McKinney <[email protected]> Closes #4824 from wesm/ARROW-5863 and squashes the following commits: ba60578 <Wes McKinney> Use atexit module for extension type finalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported on JIRA, the following script provokes a segfault
For some reason this does not trigger the destruction of the private
_ExtensionTypesInitializerobject. Not sure why (Antoine may know). Using the atexit module instead seems to do the trick