GH-47924: [C++] Fix issues in CSV reader with invalid inputs#47925
Merged
pitrou merged 3 commits intoapache:mainfrom Oct 28, 2025
Merged
GH-47924: [C++] Fix issues in CSV reader with invalid inputs#47925pitrou merged 3 commits intoapache:mainfrom
pitrou merged 3 commits intoapache:mainfrom
Conversation
pitrou
force-pushed
the
gh47924-csv-fuzz
branch
3 times, most recently
from
b35dc77 to
1e77d0e
Compare
Member
Author
|
Ouch, trying to do safe arithmetics in I've opened #47926 so that we can hopefully find another approach. |
pitrou
force-pushed
the
gh47924-csv-fuzz
branch
from
1e77d0e to
23582e7
Compare
Member
Author
|
Ouch, I hoped #47950 had fixed our problem with Windows macros but evidently it hasn't :( |
These issues were all found by OSS-Fuzz: * https://issues.oss-fuzz.com/issues/452079535 * https://issues.oss-fuzz.com/issues/452079536 * https://issues.oss-fuzz.com/issues/452118314 * https://issues.oss-fuzz.com/issues/452701622 * https://issues.oss-fuzz.com/issues/452912678
pitrou
force-pushed
the
gh47924-csv-fuzz
branch
from
23582e7 to
fb527fc
Compare
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Revision: fb527fc Submitted crossbow builds: ursacomputing/crossbow @ actions-24e5081a3b
|
adamreeve
approved these changes
Oct 27, 2025
github-actions
bot
added
awaiting committer review
HuaHuaY
reviewed
Oct 28, 2025
wgtmac
approved these changes
Oct 28, 2025
Co-authored-by: Zehua Zou <[email protected]>
Member
Author
|
Thanks all for the reviews! |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 88179b6. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Nov 5, 2025
…pache#47925) ### Rationale for this change These issues were all found by OSS-Fuzz: * https://issues.oss-fuzz.com/issues/452079535 * https://issues.oss-fuzz.com/issues/452079536 * https://issues.oss-fuzz.com/issues/452118314 * https://issues.oss-fuzz.com/issues/452701622 * https://issues.oss-fuzz.com/issues/452912678 ### Are these changes tested? Yes, by additional fuzz regression files. ### Are there any user-facing changes? No. **This PR contains a "Critical Fix".** (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.) * GitHub Issue: apache#47924 Lead-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Zehua Zou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
These issues were all found by OSS-Fuzz:
Are these changes tested?
Yes, by additional fuzz regression files.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)