ARROW-5828: [C++] Add required Protocol Buffers versions check#4785
Closed
kou wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-5828: [C++] Add required Protocol Buffers versions check#4785kou wants to merge 1 commit intoapache:masterfrom
kou wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4785 +/- ##
==========================================
+ Coverage 87.43% 89.08% +1.64%
==========================================
Files 996 719 -277
Lines 139708 100066 -39642
Branches 1418 0 -1418
==========================================
- Hits 122157 89145 -33012
+ Misses 17189 10921 -6268
+ Partials 362 0 -362Continue to review full report at Codecov.
|
kszucs
force-pushed
the
cpp-protobuf-version-check
branch
2 times, most recently
from
20405d8 to
3ac1db1
Compare
kszucs
reviewed
Jul 4, 2019
This works Protobuf_SOURCE=AUTO well on environments that have old Protocol Buffers.
kou
force-pushed
the
cpp-protobuf-version-check
branch
from
3ac1db1 to
b4e9a88
Compare
wesm
pushed a commit
that referenced
this pull request
Jul 13, 2019
This works Protobuf_SOURCE=AUTO well on environments that have old Protocol Buffers. Author: Sutou Kouhei <[email protected]> Closes #4785 from kou/cpp-protobuf-version-check and squashes the following commits: b4e9a88 <Sutou Kouhei> Add required Protocol Buffers versions check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works Protobuf_SOURCE=AUTO well on environments that have old
Protocol Buffers.