Skip to content

ARROW-5564: [C++] Use uriparser from conda-forge#4767

Closed
pitrou wants to merge 1 commit intoapache:masterfrom
pitrou:ARROW-5564-conda-uriparser
Closed

ARROW-5564: [C++] Use uriparser from conda-forge#4767
pitrou wants to merge 1 commit intoapache:masterfrom
pitrou:ARROW-5564-conda-uriparser

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jul 1, 2019

No description provided.

@kszucs
Copy link
Member

kszucs commented Jul 1, 2019

@pitrou please add it to the crossbow conda build too https://github.com/apache/arrow/blob/master/dev/tasks/conda-recipes/arrow-cpp/meta.yaml

@pitrou pitrou force-pushed the ARROW-5564-conda-uriparser branch from 86e765f to a97b036 Compare July 1, 2019 13:54
@pitrou
Copy link
Member Author

pitrou commented Jul 1, 2019

@kszucs Done.

@pitrou
Copy link
Member Author

pitrou commented Jul 1, 2019

AppVeyor after the uriparser package was actually available on conda-forge: https://ci.appveyor.com/project/pitrou/arrow/builds/25664179

@pitrou pitrou force-pushed the ARROW-5564-conda-uriparser branch from a97b036 to 3c422c9 Compare July 1, 2019 15:30
@kszucs
Copy link
Member

kszucs commented Jul 1, 2019

Also run ursabot crossbow package -g conda after uriparser gets available.

@pitrou
Copy link
Member Author

pitrou commented Jul 1, 2019

@ursabot crossbow package -g conda

@ursabot
Copy link

ursabot commented Jul 1, 2019

AMD64 Conda Crossbow (#29206) builder has been succeeded.

Revision: 3c422c9

Submitted crossbow builds: ursa-labs/crossbow @ ursabot-101

Task Status
conda-linux-gcc-py27 Azure
conda-linux-gcc-py36 Azure
conda-linux-gcc-py37 Azure
conda-osx-clang-py27 Azure
conda-osx-clang-py36 Azure
conda-osx-clang-py37 Azure
conda-win-vs2015-py36 Appveyor
conda-win-vs2015-py37 Appveyor

@pitrou
Copy link
Member Author

pitrou commented Jul 1, 2019

Hmm, one of the AppVeyor builds took too long (more than 1 hour)!

@kszucs
Copy link
Member

kszucs commented Jul 1, 2019

Yep, we should move the the windows builds to azure as well, but CF still has issues with it.

wesm
wesm approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 8ec2fd0 Jul 1, 2019
@pitrou pitrou deleted the ARROW-5564-conda-uriparser branch July 2, 2019 08:19
kou pushed a commit that referenced this pull request Jul 4, 2019
@pitrou @kou
ARROW-5564: [C++] Use uriparser from conda-forge
88fcb09 
Author: Antoine Pitrou <[email protected]>

Closes #4767 from pitrou/ARROW-5564-conda-uriparser and squashes the following commits:

3c422c9 <Antoine Pitrou> ARROW-5564:  Use uriparser from conda-forge
wesm pushed a commit that referenced this pull request Jul 13, 2019
@pitrou @wesm
ARROW-5564: [C++] Use uriparser from conda-forge
07b3695 
Author: Antoine Pitrou <[email protected]>

Closes #4767 from pitrou/ARROW-5564-conda-uriparser and squashes the following commits:

3c422c9 <Antoine Pitrou> ARROW-5564:  Use uriparser from conda-forge
@asfimport asfimport mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou @kszucs @ursabot @wesm