ARROW-5609: [C++] Set CMP0068 CMake policy to avoid macOS warnings#4752
Closed
xhochy wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-5609: [C++] Set CMP0068 CMake policy to avoid macOS warnings#4752xhochy wants to merge 1 commit intoapache:masterfrom
xhochy wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4752 +/- ##
==========================================
+ Coverage 86.44% 88.93% +2.49%
==========================================
Files 992 717 -275
Lines 138020 98865 -39155
Branches 1418 0 -1418
==========================================
- Hits 119311 87926 -31385
+ Misses 18347 10939 -7408
+ Partials 362 0 -362Continue to review full report at Codecov.
|
kou
pushed a commit
that referenced
this pull request
Jul 4, 2019
C++ and Python Tests pass locally so this seems to be ok for us. Author: Uwe L. Korn <[email protected]> Closes #4752 from xhochy/ARROW-5609 and squashes the following commits: 6e087d6 <Uwe L. Korn> ARROW-5609: Set CMP0068 CMake policy to avoid macOS warnings
wesm
pushed a commit
that referenced
this pull request
Jul 13, 2019
C++ and Python Tests pass locally so this seems to be ok for us. Author: Uwe L. Korn <[email protected]> Closes #4752 from xhochy/ARROW-5609 and squashes the following commits: 6e087d6 <Uwe L. Korn> ARROW-5609: Set CMP0068 CMake policy to avoid macOS warnings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4752 +/- ##
==========================================
+ Coverage 86.44% 88.93% +2.49%
==========================================
Files 992 717 -275
Lines 138020 98865 -39155
Branches 1418 0 -1418
==========================================
- Hits 119311 87926 -31385
+ Misses 18347 10939 -7408
+ Partials 362 0 -362 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ and Python Tests pass locally so this seems to be ok for us.