Repository navigation
GH-46771: [Python][C++] Implement pa.arange function to generate array sequences - #46778
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
raulcd
commented
Jun 11, 2025
raulcd
left a comment
raulcd
left a comment
Member
Author
There was a problem hiding this comment.
I am unsure whether this is what you had in mind @pitrou but would appreciate some tips on possible improvements. I've been testing and it stills is slightly slower than the np.arange original implementation. With the original np.arange implementation:
In [2]: a = pa.array(np.arange(0, 2_000_000))
In [3]: %timeit a[slice(1, 1_000_000, 2)]
763 μs ± 4.28 μs per loop (mean ± std. dev. of 7 runs, 1,000 loops each
with the current PR one:
In [2]: a = pa.array(np.arange(0, 2_000_000))
In [3]: %timeit a[slice(1, 1_000_000, 2)]
1.08 ms ± 43.7 μs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)
raulcd
changed the title
|
|
Member
Author
|
It seems to be on-pair now: In [2]: %timeit np.arange(1, 1_000_000, 2)
219 μs ± 10.6 μs per loop (mean ± std. dev. of 7 runs, 1,000 loops each)
In [3]: %timeit pa.arange(1, 1_000_000, 2)
212 μs ± 1.97 μs per loop (mean ± std. dev. of 7 runs, 1,000 loops each) |
pitrou
reviewed
Jun 11, 2025
pitrou
reviewed
Jun 11, 2025
pitrou
reviewed
Jun 11, 2025
pitrou
reviewed
Jun 11, 2025
pitrou
reviewed
Jun 11, 2025
…e interesting test cases
pitrou
reviewed
Jun 18, 2025
pitrou
reviewed
Jun 18, 2025
rok
approved these changes
Jun 20, 2025
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b3e261d. There were 122 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This was referenced Jul 10, 2025
This was referenced Jul 19, 2025
4 of 10 tasks
This was referenced Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When slicing arrays with non-trivial steps we were using
numpy.arangeto generate the indices for take. As numpy is an optional dependency, implementing it via Python caused a performance penalty. Creating a pyarrow function to build our own ranges that mimics Python range or numpy arange is useful for that uses case and might also be useful for other use cases. Currently we only generateArray[Int64]we could potentially generate more types.What changes are included in this PR?
provide a
pa.arangefunction that allows us to generate indices when slicing arrays.Are these changes tested?
Yes new tests added.
Are there any user-facing changes?
No but a new pyarrow.arange function has been added.