Repository navigation
GH-46516: [CI][Python] Force Cython>3.1.1 for docs builds - #46770
Conversation
|
|
github-actions
Bot
added
Component: Python
awaiting change review
and removed
awaiting changes
labels
| # If we are building docs we force Cython>3.1.1 to avoid numpydoc | ||
| # failures due to Cython docstring being wrongly generated. | ||
| if [ "${BUILD_DOCS_PYTHON}" == "ON" ]; then | ||
| ${PYTHON:-python} -m pip install --upgrade Cython>3.1.1 |
There was a problem hiding this comment.
Will that work properly if Cython was installed using conda?
Also, is this necessary at all?
There was a problem hiding this comment.
Will that work properly if Cython was installed using conda?
It does fix the existing failures which install Cython through conda, so the answer seems to be yes (without this it still fails) because the cached docker image installed Cython 3.1.1
Also, is this necessary at all?
I don't think we should merge that specific change, I was validating the existing failing CI jobs.
I think the bests course of action would be to force rebuild the underlying docker image so it is not caches and it installs Cython 3.1.2. I am asking on Zulip if someone has access to docker.io/apache/arrow-dev as rebuilding the image would fix the issue
…txt and conda_env_sphinx
github-actions
Bot
added
Component: Documentation
awaiting change review
and removed
awaiting changes
labels
raulcd
changed the title
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d2a8b78. There were 70 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 49 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…he#46770) ### Rationale for this change Due to a change of behaviour on Cython for 3.1 the docstrings generated fail when being tested with numpydoc. The issue was fixed on Cython==3.1.2. - cython/cython#6904 ### What changes are included in this PR? - Pin Cython>3.1.1 for the docs requirements (both conda and pip) - Fix doctest failure that was introduced in the interim when the CI job had been failing. ### Are these changes tested? Via CI. ### Are there any user-facing changes? No * GitHub Issue: apache#46516 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Due to a change of behaviour on Cython for 3.1 the docstrings generated fail when being tested with numpydoc. The issue was fixed on Cython==3.1.2.
\n\ncython/cython#6904What changes are included in this PR?
Are these changes tested?
Via CI.
Are there any user-facing changes?
No