GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh by hiroyuki-sato · Pull Request #46727 · apache/arrow

hiroyuki-sato · 2025-06-06T05:38:35Z

Rationale for this change

This is the sub issue #44748.

SC2046 -- Quote this to prevent word splitt...
SC2206 -- Quote to prevent word splitting/g...
SC2086 -- Double quote to prevent globbing ...

In ci/scripts/conan_build.sh line 32:
  conan_args+=(--options arrow/*:parquet=${ARROW_CONAN_PARQUET})
                                         ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 33:
  conan_args+=(--options arrow/*:with_thrift=${ARROW_CONAN_PARQUET})
                                             ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 34:
  conan_args+=(--options arrow/*:with_boost=${ARROW_CONAN_PARQUET})
                                            ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 37:
  conan_args+=(--options arrow/*:with_brotli=${ARROW_CONAN_WITH_BROTLI})
                                             ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 40:
  conan_args+=(--options arrow/*:with_bz2=${ARROW_CONAN_WITH_BZ2})
                                          ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 43:
  conan_args+=(--options arrow/*:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                                 ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 44:
  conan_args+=(--options arrow/*:with_grpc=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                           ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 45:
  conan_args+=(--options arrow/*:with_protobuf=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                               ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 46:
  conan_args+=(--options arrow/*:with_re2=${ARROW_CONAN_WITH_FLIGHT_RPC})
                                          ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 49:
  conan_args+=(--options arrow/*:with_glog=${ARROW_CONAN_WITH_GLOG})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 52:
  conan_args+=(--options arrow/*:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC})
                                               ^--------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 55:
  conan_args+=(--options arrow/*:with_json=${ARROW_CONAN_WITH_JSON})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 58:
  conan_args+=(--options arrow/*:with_lz4=${ARROW_CONAN_WITH_LZ4})
                                          ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 61:
  conan_args+=(--options arrow/*:with_snappy=${ARROW_CONAN_WITH_SNAPPY})
                                             ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 64:
  conan_args+=(--options arrow/*:with_zstd=${ARROW_CONAN_WITH_ZSTD})
                                           ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 67:
version=$(grep '^set(ARROW_VERSION ' ${ARROW_HOME}/cpp/CMakeLists.txt | \
                                     ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
version=$(grep '^set(ARROW_VERSION ' "${ARROW_HOME}"/cpp/CMakeLists.txt | \


In ci/scripts/conan_build.sh line 69:
conan_args+=(--version ${version})
                       ^--------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.


In ci/scripts/conan_build.sh line 72:
rm -rf ${build_dir}/conan || sudo rm -rf ${build_dir}/conan
       ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
rm -rf "${build_dir}"/conan || sudo rm -rf "${build_dir}"/conan


In ci/scripts/conan_build.sh line 73:
mkdir -p ${build_dir}/conan || sudo mkdir -p ${build_dir}/conan
         ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                             ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
mkdir -p "${build_dir}"/conan || sudo mkdir -p "${build_dir}"/conan


In ci/scripts/conan_build.sh line 74:
if [ -w ${build_dir} ]; then
        ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
if [ -w "${build_dir}" ]; then


In ci/scripts/conan_build.sh line 75:
  cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
        ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                 ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 77:
  sudo cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/
             ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                      ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  sudo cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 78:
  sudo chown -R $(id -u):$(id -g) ${build_dir}/conan/
                ^------^ SC2046 (warning): Quote this to prevent word splitting.
                         ^------^ SC2046 (warning): Quote this to prevent word splitting.
                                  ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
  sudo chown -R $(id -u):$(id -g) "${build_dir}"/conan/


In ci/scripts/conan_build.sh line 80:
cd ${build_dir}/conan/all
   ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.

Did you mean:
cd "${build_dir}"/conan/all

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...

What changes are included in this PR?

Add quote like "${ARROW_CONAN_PARQUET}"

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46726

github-actions · 2025-06-06T05:39:02Z

⚠️ GitHub issue #46726 has been automatically assigned in GitHub to PR creator.

kou · 2025-06-06T06:31:18Z

@github-actions crossbow submit -g conan

kou · 2025-06-06T06:31:50Z

ci/scripts/conan_build.sh

Suggested change

conan_args+=(--options arrow/*:parquet="${ARROW_CONAN_PARQUET}")

conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}")

I want to double check just in case.
Does the '*' character is just the character not a wildcard character ?

And suggested change means not only parquet but also with_thrift and with_boost too?

conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}") conan_args+=(--options "arrow/*:with_thrift=${ARROW_CONAN_PARQUET}") conan_args+=(--options "arrow/*:with_boost=${ARROW_CONAN_PARQUET}")

and the rest of belows

if [ -n "${ARROW_CONAN_WITH_GLOG:-}" ]; then conan_args+=(--options arrow/*:with_glog="${ARROW_CONAN_WITH_GLOG}") fi if [ -n "${ARROW_CONAN_WITH_JEMALLOC:-}" ]; then conan_args+=(--options arrow/*:with_jemalloc="${ARROW_CONAN_WITH_JEMALLOC}") fi if [ -n "${ARROW_CONAN_WITH_JSON:-}" ]; then conan_args+=(--options arrow/*:with_json="${ARROW_CONAN_WITH_JSON}") fi if [ -n "${ARROW_CONAN_WITH_LZ4:-}" ]; then conan_args+=(--options arrow/*:with_lz4="${ARROW_CONAN_WITH_LZ4}") fi if [ -n "${ARROW_CONAN_WITH_SNAPPY:-}" ]; then conan_args+=(--options arrow/*:with_snappy="${ARROW_CONAN_WITH_SNAPPY}") fi if [ -n "${ARROW_CONAN_WITH_ZSTD:-}" ]; then conan_args+=(--options arrow/*:with_zstd="${ARROW_CONAN_WITH_ZSTD}") fi

Thanks! done.

ci/scripts/conan_build.sh

github-actions · 2025-06-06T06:33:42Z

Revision: 07e75ebc00bbce24557c3f5a90ca0974eaea03f3

Submitted crossbow builds: ursacomputing/crossbow @ actions-fad6f67540

Task	Status
conan-maximum
conan-minimum

hiroyuki-sato · 2025-06-06T08:42:37Z

It seems that conan-minimum can't find RapidJSON package.

https://github.com/ursacomputing/crossbow/actions/runs/15484349076/job/43595828887#step:6:1006

-- Conan: Including build module from '/root/.conan2/p/opens291bcb59a86d6/p/lib/cmake/conan-official-openssl-variables.cmake'
-- Providing CMake module for FindThriftAlt as part of Parquet CMake package
-- pkg-config package for thrift that is used by parquet for static link isn't found
CMake Warning at cmake_modules/FindRapidJSONAlt.cmake:29 (find_package):
  By not providing "FindRapidJSON.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "RapidJSON", but CMake did not find one.

  Could not find a package configuration file provided by "RapidJSON"
  (requested version 1.1.0) with any of the following names:

    RapidJSONConfig.cmake
    rapidjson-config.cmake

  Add the installation prefix of "RapidJSON" to CMAKE_PREFIX_PATH or set
  "RapidJSON_DIR" to a directory containing one of the above files.  If
  "RapidJSON" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  cmake_modules/ThirdpartyToolchain.cmake:310 (find_package)
  cmake_modules/ThirdpartyToolchain.cmake:2538 (resolve_dependency)
  CMakeLists.txt:618 (include)


CMake Error at /root/.conan2/p/cmakee7c682f30a1a9/p/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
  Could NOT find RapidJSONAlt (missing: RAPIDJSON_INCLUDE_DIR) (Required is
  at least version "1.1.0")
Call Stack (most recent call first):
  /root/.conan2/p/cmakee7c682f30a1a9/p/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)

kou · 2025-06-06T22:56:10Z

Let's fix the failure before this.

hiroyuki-sato · 2025-06-07T01:53:39Z

Thanks. I reverted all commits for testing conan-minimum build failure. After resolve build failure I will modify quote again.

hiroyuki-sato · 2025-06-07T01:53:45Z

@github-actions crossbow submit -g conan

github-actions · 2025-06-07T01:55:59Z

Revision: c488ecb40159bde7a0cdb5d7f35aaf1dc0bfafcd

Submitted crossbow builds: ursacomputing/crossbow @ actions-e4ffbae60d

Task	Status
conan-maximum
conan-minimum

hiroyuki-sato · 2025-06-07T02:44:46Z

conan-minimum build failure unrelated this change.

…an_build.sh

Co-authored-by: Sutou Kouhei <[email protected]>

…an_build.sh

…ipts/conan_build.sh" This reverts commit 07e75ebc00bbce24557c3f5a90ca0974eaea03f3~1..

…ripts/conan_build.sh" This reverts commit c488ecb40159bde7a0cdb5d7f35aaf1dc0bfafcd.

…an_build.sh

hiroyuki-sato · 2025-06-10T04:35:55Z

@github-actions crossbow submit -g conan

github-actions · 2025-06-10T04:38:06Z

Revision: c87a7f6

Submitted crossbow builds: ursacomputing/crossbow @ actions-ea3a3a556d

Task	Status
conan-maximum
conan-minimum

hiroyuki-sato · 2025-06-10T05:07:38Z

@kou crossbow passed. Please take a look when you get a chance.

kou

+1

conbench-apache-arrow · 2025-06-10T14:22:36Z

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f6bc089.

There were 68 benchmark results with an error:

Commit Run on arm64-t4g-2xlarge-linux at 2025-06-10 07:40:49Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1
and 66 more (see the report linked below)

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 146 possible false positives for unstable benchmarks that are known to sometimes produce them.

…an_build.sh (apache#46727) ### Rationale for this change This is the sub issue apache#44748. * SC2046 -- Quote this to prevent word splitt... * SC2206 -- Quote to prevent word splitting/g... * SC2086 -- Double quote to prevent globbing ... ``` In ci/scripts/conan_build.sh line 32: conan_args+=(--options arrow/*:parquet=${ARROW_CONAN_PARQUET}) ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 33: conan_args+=(--options arrow/*:with_thrift=${ARROW_CONAN_PARQUET}) ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 34: conan_args+=(--options arrow/*:with_boost=${ARROW_CONAN_PARQUET}) ^--------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 37: conan_args+=(--options arrow/*:with_brotli=${ARROW_CONAN_WITH_BROTLI}) ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 40: conan_args+=(--options arrow/*:with_bz2=${ARROW_CONAN_WITH_BZ2}) ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 43: conan_args+=(--options arrow/*:with_flight_rpc=${ARROW_CONAN_WITH_FLIGHT_RPC}) ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 44: conan_args+=(--options arrow/*:with_grpc=${ARROW_CONAN_WITH_FLIGHT_RPC}) ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 45: conan_args+=(--options arrow/*:with_protobuf=${ARROW_CONAN_WITH_FLIGHT_RPC}) ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 46: conan_args+=(--options arrow/*:with_re2=${ARROW_CONAN_WITH_FLIGHT_RPC}) ^----------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 49: conan_args+=(--options arrow/*:with_glog=${ARROW_CONAN_WITH_GLOG}) ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 52: conan_args+=(--options arrow/*:with_jemalloc=${ARROW_CONAN_WITH_JEMALLOC}) ^--------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 55: conan_args+=(--options arrow/*:with_json=${ARROW_CONAN_WITH_JSON}) ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 58: conan_args+=(--options arrow/*:with_lz4=${ARROW_CONAN_WITH_LZ4}) ^---------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 61: conan_args+=(--options arrow/*:with_snappy=${ARROW_CONAN_WITH_SNAPPY}) ^------------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 64: conan_args+=(--options arrow/*:with_zstd=${ARROW_CONAN_WITH_ZSTD}) ^----------------------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 67: version=$(grep '^set(ARROW_VERSION ' ${ARROW_HOME}/cpp/CMakeLists.txt | \ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: version=$(grep '^set(ARROW_VERSION ' "${ARROW_HOME}"/cpp/CMakeLists.txt | \ In ci/scripts/conan_build.sh line 69: conan_args+=(--version ${version}) ^--------^ SC2206 (warning): Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. In ci/scripts/conan_build.sh line 72: rm -rf ${build_dir}/conan || sudo rm -rf ${build_dir}/conan ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: rm -rf "${build_dir}"/conan || sudo rm -rf "${build_dir}"/conan In ci/scripts/conan_build.sh line 73: mkdir -p ${build_dir}/conan || sudo mkdir -p ${build_dir}/conan ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: mkdir -p "${build_dir}"/conan || sudo mkdir -p "${build_dir}"/conan In ci/scripts/conan_build.sh line 74: if [ -w ${build_dir} ]; then ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: if [ -w "${build_dir}" ]; then In ci/scripts/conan_build.sh line 75: cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/ In ci/scripts/conan_build.sh line 77: sudo cp -a ${source_dir}/ci/conan/* ${build_dir}/conan/ ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sudo cp -a "${source_dir}"/ci/conan/* "${build_dir}"/conan/ In ci/scripts/conan_build.sh line 78: sudo chown -R $(id -u):$(id -g) ${build_dir}/conan/ ^------^ SC2046 (warning): Quote this to prevent word splitting. ^------^ SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: sudo chown -R $(id -u):$(id -g) "${build_dir}"/conan/ In ci/scripts/conan_build.sh line 80: cd ${build_dir}/conan/all ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cd "${build_dir}"/conan/all For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2206 -- Quote to prevent word splitting/g... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ``` ### What changes are included in this PR? Add quote like `"${ARROW_CONAN_PARQUET}"` ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46726 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

hiroyuki-sato requested review from assignUser, jonkeane, kou and raulcd as code owners June 6, 2025 05:38

github-actions bot added the awaiting review Awaiting review label Jun 6, 2025

kou reviewed Jun 6, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting review Awaiting review awaiting changes Awaiting changes awaiting change review Awaiting change review labels Jun 6, 2025

hiroyuki-sato changed the title ~~GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh~~ [DNN] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh Jun 7, 2025

hiroyuki-sato changed the title ~~[DNN] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh~~ [DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh Jun 7, 2025

hiroyuki-sato mentioned this pull request Jun 7, 2025

[CI] conan-minimum build failure with RapidJSON missing error #46736

Closed

hiroyuki-sato and others added 4 commits June 10, 2025 13:23

apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/con…

b581a64

…an_build.sh

Update ci/scripts/conan_build.sh

123f691

Co-authored-by: Sutou Kouhei <[email protected]>

apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/con…

16999da

…an_build.sh

Revert "apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/scr…

b894aef

…ipts/conan_build.sh" This reverts commit 07e75ebc00bbce24557c3f5a90ca0974eaea03f3~1..

hiroyuki-sato added 3 commits June 10, 2025 13:28

Reapply "apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/sc…

62c6767

…ripts/conan_build.sh" This reverts commit c488ecb40159bde7a0cdb5d7f35aaf1dc0bfafcd.

Fix merge conflict

ab05c5c

apacheGH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/con…

c87a7f6

…an_build.sh

hiroyuki-sato force-pushed the topic/shellcheck-conan_build branch from 7bd880b to c87a7f6 Compare June 10, 2025 04:31

hiroyuki-sato changed the title ~~[DNM] GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh~~ GH-46726: [CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh Jun 10, 2025

kou approved these changes Jun 10, 2025

View reviewed changes

github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 10, 2025

kou merged commit f6bc089 into apache:main Jun 10, 2025
13 of 15 checks passed

kou removed the awaiting merge Awaiting merge label Jun 10, 2025

kou mentioned this pull request Jun 10, 2025

[CI][Dev] fix shellcheck errors in the ci/scripts/conan_build.sh #46726

Closed

hiroyuki-sato deleted the topic/shellcheck-conan_build branch June 10, 2025 06:38

	conan_args+=(--options arrow/*:parquet="${ARROW_CONAN_PARQUET}")
	conan_args+=(--options "arrow/*:parquet=${ARROW_CONAN_PARQUET}")

Conversation

hiroyuki-sato commented Jun 6, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

kou commented Jun 6, 2025

Uh oh!

kou Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kou Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

hiroyuki-sato Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jun 6, 2025

Uh oh!

hiroyuki-sato commented Jun 6, 2025

Uh oh!

kou commented Jun 6, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

github-actions bot commented Jun 7, 2025

Uh oh!

hiroyuki-sato commented Jun 7, 2025

Uh oh!

hiroyuki-sato commented Jun 10, 2025

Uh oh!

github-actions bot commented Jun 10, 2025

Uh oh!

hiroyuki-sato commented Jun 10, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conbench-apache-arrow bot commented Jun 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hiroyuki-sato commented Jun 6, 2025 •

edited by github-actions bot

Loading

hiroyuki-sato Jun 6, 2025 •

edited

Loading