Skip to content

GH-46632: [R][Docs] Add docs for arrow::one - #46648

Merged
amoeba merged 1 commit into
apache:mainfrom
amoeba:fix/GH-46632--r-document-one
Jun 2, 2025
Merged

amoeba merged 1 commit into
apache:mainfrom
amoeba:fix/GH-46632--r-document-one

Conversation

@amoeba

@amoeba amoeba commented May 30, 2025 •

Copy link
Copy Markdown
Member

Rationale for this change

Adds missing documentation for the arrow::one binding.

What changes are included in this PR?

I pulled out the inline definition into a standalone one so we can document it with Roxygen and added Roxygen docs. I cherry-picked d03d3e7 to do this.

Are these changes tested?

Yes. I cherry-picked d03d3e7 which I've tested previously.

Are there any user-facing changes?

No.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #46632 has been automatically assigned in GitHub to PR creator.

@thisisnic thisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @amoeba!

@amoeba
amoeba merged commit 22acbc9 into apache:main Jun 2, 2025
@amoeba

amoeba commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @thisisnic.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 22acbc9.

There were 70 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 104 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants