GH-46623: [C++][Compute] Fix the failure of large memory test in arrow-compute-row-test#46635
GH-46623: [C++][Compute] Fix the failure of large memory test in arrow-compute-row-test#46635pitrou merged 1 commit intoapache:mainfrom
Conversation
|
I guess the CI won't tell us anything (the large memory tests are not ran by default). Feel free to try in your local @pitrou . Thanks. |
Yes. For the record, I've opened #46600 for it (and this is how I found out that this test was failing). |
|
Rebased in the hope of getting greener CI./ |
Well, of course, this is a bit futile since the test won't run anyway. I'll merge :) |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c2fb0e3. There were 68 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
In #45336 we refined the row table buffer accessors and enforced the validation on who can call the
var_length_rows()method. However a legacy testCompareColumnsToRowsOver4GBFixedLengthis leveraging this accessor to assert this buffer being null.What changes are included in this PR?
We can just check if the row table is fixed length.
Are these changes tested?
Yes.
Are there any user-facing changes?
None.