ARROW-603: [C++] Add RecordBatch::Validate method, call in RecordBatch ctor in debug builds #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilds Change-Id: I4ee527dbb27e3e4988062c7d39ab2dc2f56cefd7
xhochy
reviewed
Mar 31, 2017
| NAMES clang-tidy-3.8 clang-tidy-3.7 clang-tidy-3.6 clang-tidy | ||
| PATHS ${ClangTools_PATH} $ENV{CLANG_TOOLS_PATH} /usr/local/bin /usr/bin | ||
| find_program(CLANG_TIDY_BIN | ||
| NAMES clang-format-4.0 clang-format-3.9 clang-tidy-3.8 clang-tidy-3.7 clang-tidy-3.6 clang-tidy |
Change-Id: Ife0885d3815e57f7c7c2835970128c588e84ec42
xhochy
approved these changes
Mar 31, 2017
Member
Author
|
Thanks! here's the appveyor build: https://ci.appveyor.com/project/wesm/arrow/build/1.0.44 |
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
In recent Arrow builds, ReadAt() doesn't specify whether it updates the file position or not. (ideally, it does not, but on certain platforms the file position may be updated anyway -- e.g. Windows) Author: Antoine Pitrou <[email protected]> Closes apache#466 from pitrou/PARQUET-1307-memory-test-fix and squashes the following commits: ffd6dc0 [Antoine Pitrou] PARQUET-1307: Fix memory-test for newer Arrow Change-Id: I24b7aeef37f4dd0999d72213921527af846f7478
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function will help catch malformed RecordBatch objects during development