Repository navigation
GH-37027: [C++] Add float16 kernels to if-else and vector-replace functions - #46446
Merged
pitrou merged 4 commits intoJun 30, 2025
Merged
Conversation
|
|
Member
|
@colin-r-schultz Is this ready for review? |
Contributor
Author
|
@pitrou Yes! |
pitrou
force-pushed
the
halffloat-type-agnostic-primitive
branch
from
June 30, 2025 15:00
28a77b8 to
7e37931
Compare
pitrou
approved these changes
Jun 30, 2025
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay @colin-r-schultz . This looks good to me, thanks a lot for your contribution!
Member
|
I rebased from git main, I'll merge if CI passes. |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 84d9c88. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Support float16/halffloat type in some functions which are agnostic to the numeric value.
replace_with_maskas requested in [C++] Missing kernel for replace_with_mask with halffloat #37027What changes are included in this PR?
GenerateTypeAgnosticPrimitiveforHALF_FLOATfloat16kernels forif_else,case_when,coalesce, andchoosefloat16kernels forreplace_with_mask,fill_null_forward,fill_null_backwardHalfFloatTypeto the list of types tested for the above functionsAre these changes tested?
Yes
Are there any user-facing changes?
Functions listed above now support float16