GH-45980: [C++] Bump Bundled Snappy version to 1.2.2#45981
GH-45980: [C++] Bump Bundled Snappy version to 1.2.2#45981assignUser merged 3 commits intoapache:mainfrom
Conversation
|
@github-actions crossbow submit test-conda-python-emscripten r-binary-packages |
|
Revision: 61d9a6d86cceb54be7ad4e22a7a330a87cb864b1 Submitted crossbow builds: ursacomputing/crossbow @ actions-4f13d7efec
|
|
@github-actions crossbow submit test-conda-python-emscripten |
|
Revision: 61d9a6d86cceb54be7ad4e22a7a330a87cb864b1 Submitted crossbow builds: ursacomputing/crossbow @ actions-43a7b8e298
|
|
I am just confused on why the job uses CMake 4.0 on CI but I have to force installation of CMake 4.0 locally even when forcing rebuilding local images, etcetera. |
|
Can you rebase this now? |
|
@github-actions crossbow submit -g cpp r-binary-packages |
|
Revision: 77ec39f Submitted crossbow builds: ursacomputing/crossbow @ actions-3d90fd57f2
|
| # We set CMAKE_POLICY_VERSION_MINIMUM temporarily due to failures with CMake 4 | ||
| # We should remove it once we have updated the dependencies: | ||
| # https://github.com/apache/arrow/issues/45985 | ||
| -DCMAKE_POLICY_VERSION_MINIMUM=3.5) |
There was a problem hiding this comment.
Can we disable this in build_snappy?
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index f4de617ced..21676ea5f1 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1387,6 +1387,9 @@ macro(build_snappy)
set(SNAPPY_CMAKE_ARGS
${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF -DSNAPPY_BUILD_BENCHMARKS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
+ # We can remove this once we remove -DCMAKE_POLICY_VERSION_MINIMUM=3.5
+ # from EP_COMMON_CMAKE_ARGS.
+ list(REMOVE_ITEM SNAPPY_CMAKE_ARGS -DCMAKE_POLICY_VERSION_MINIMUM=3.5)
# Snappy unconditionally enables -Werror when building with clang this can lead
# to build failures by way of new compiler warnings. This adds a flag to disable
# -Werror to the very end of the invocation to override the snappy internal setting.
github-actions
bot
added
awaiting merge
|
@github-actions crossbow submit test-ubuntu-22.04-cpp-emscripten |
|
Revision: 7652f19 Submitted crossbow builds: ursacomputing/crossbow @ actions-736994d413
|
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 686971e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 30 possible false positives for unstable benchmarks that are known to sometimes produce them. |
) ### Rationale for this change CMake 4.0 removed 3.5 as a viable minimum version. ### What changes are included in this PR? Bump bundled snappy. ### Are these changes tested? CI ### Are there any user-facing changes? No. * GitHub Issue: apache#45980 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
) ### Rationale for this change CMake 4.0 removed 3.5 as a viable minimum version. ### What changes are included in this PR? Bump bundled snappy. ### Are these changes tested? CI ### Are there any user-facing changes? No. * GitHub Issue: apache#45980 Authored-by: Jacob Wujciak-Jens <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
4 participants
Rationale for this change
CMake 4.0 removed 3.5 as a viable minimum version.
What changes are included in this PR?
Bump bundled snappy.
Are these changes tested?
CI
Are there any user-facing changes?
No.